phares3757/mesa-fab-approval
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merged PR 12625: Fix: Incorrectly creating new training records when canceling a TECN

Browse Source 
Fix: Incorrectly creating new training records when canceling a TECN

IDE0100

Updated pipelines to build package .zip for msdeploy.exe

Related work items: #239935
This commit is contained in:
Mike Phares
2025-03-11 20:16:18 +01:00
parent 55d3a96228
commit 2119b31764
8 changed files with 162 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Fab2ApprovalSystem/DMO/AdminDMO.cs
View File

@ -37,7 +37,7 @@ public class AdminDMO {
foreach (SubRole sr in r.SubRoles) {
if (sr.Inactive) {
// hide inactive roles unless parameter says otherwise
if (showInactiveRoles.Equals("true") == false)
if (!showInactiveRoles.Equals("true"))
continue;
}

4
Fab2ApprovalSystem/DMO/AuditDMO.cs
View File

@ -414,7 +414,7 @@ public class AuditDMO {
if (audit.OriginatorID == userId) {
result.IsSubmitter = true;
}
if (isAdmin != true) {
if (!isAdmin) {
result.IsAdmin = false;
} else {
result.IsAdmin = true;
@ -424,7 +424,7 @@ public class AuditDMO {
{
result.RedirectToAction = true;
}
if (result.IsAdmin == false && result.IsSubmitter == false) {
if (!result.IsAdmin && !result.IsSubmitter) {
result.RedirectToAction = true;
} else {
result.UserList = GetUserList();

2
Fab2ApprovalSystem/DMO/CorrectiveActionDMO.cs
View File

@ -324,7 +324,7 @@ public class CorrectiveActionDMO {
bool isAssignee = false;
int aiIndex = 0;
List<D5D6CorrectivetAction> actionItems = GetD5D6CorrectivetActions(caId).ToList();
while (isAssignee == false && aiIndex < actionItems.Count) {
while (!isAssignee && aiIndex < actionItems.Count) {
D5D6CorrectivetAction actionItem = actionItems[aiIndex];
if (actionItem.ResponsibilityOwnerID == userId && actionItem.ImplementedDate == null && actionItem.Approved) {
isAssignee = true;

4
Fab2ApprovalSystem/DMO/MRB_DMO.cs
View File

@ -266,9 +266,9 @@ public class MRB_DMO {
DateTime? issueStartDate = tempMRBInfo.IssueStartDate;
DateTime? issueEndDate = tempMRBInfo.IssueEndDate;
if (issueStartDate.HasValue == false)
if (!issueStartDate.HasValue)
throw new Exception("MRB Issue Start Date cannot be blank");
if (issueEndDate.HasValue == false)
if (!issueEndDate.HasValue)
throw new Exception("MRB Issue End Date cannot be blank");
MRB mrbData = new() { MRBNumber = mrbNumber, ToolCSV = tempMRBInfo.ToolCSV, IssueStartDate = tempMRBInfo.IssueStartDate, IssueEndDate = tempMRBInfo.IssueEndDate };

2
Fab2ApprovalSystem/DMO/WorkflowDMO.cs
View File

@ -166,7 +166,7 @@ public class WorkflowDMO {
sqlString.Append("SELECT COUNT(*) FROM LotDisposition LD INNER JOIN Lot L ON LD.IssueID = L.IssueID ");
sqlString.Append("WHERE (PERequired = 1 OR Location = 'QDB' OR Location = 'EDB' ) AND LD.IssueID = @IssueID ");
recordCount = db.Query<int>(sqlString.ToString(), new { IssueID = issueID }).Single();
if ((recordCount > 0) && (allLotsAreScrap == false)) {
if ((recordCount > 0) && (!allLotsAreScrap)) {
// check if there any IG Medical products
if (recordCountForIG_MA > 0) {
sqlString = new StringBuilder();