phares3757/mesa-fab-approval
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merged PR 12196: Alphabetize Category List -ECN Module

Browse Source 
Moved pipeline to align with other projects in same repo

Changed MSBuild task to be specific and added new MSBuild Release task

Sort GetCategories on CategoryName

Added comments back from feature 135470

Added ItemGroup to allow testing internal methods

Testing for internal methods

Related work items: #135470, #238416
This commit is contained in:
Mike Phares 2025-03-05 19:27:20 +01:00
parent aa38d17daf
commit 55d3a96228
7 changed files with 36 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
.vscode/tasks.json vendored
View File

@ -2,7 +2,7 @@
"version": "2.0.0",
"tasks": [
{
"label": "MSBuild",
"label": "MSBuild-Debug",
"command": "C:/Program Files (x86)/Microsoft Visual Studio/2022/BuildTools/MSBuild/Current/Bin/MSBuild.exe",
"type": "process",
"args": [
@ -16,6 +16,21 @@
],
"problemMatcher": "$msCompile"
},
{
"label": "MSBuild-Release",
"command": "C:/Program Files (x86)/Microsoft Visual Studio/2022/BuildTools/MSBuild/Current/Bin/MSBuild.exe",
"type": "process",
"args": [
"/target:Build",
"/restore:True",
"/p:RestoreSources=https://artifactory.intra.infineon.com/artifactory/api/nuget/ngt-fi-package-main-vir/%3Bhttps://packagemanagement.eu.infineon.com:4430/api/v2/%3Bhttps://api.nuget.org/v3/index.json",
"/detailedsummary",
"/consoleloggerparameters:PerformanceSummary;ErrorsOnly;",
"/property:Configuration=Release;TargetFrameworkVersion=v4.8",
"Fab2ApprovalSystem/Fab2ApprovalSystem.csproj"
],
"problemMatcher": "$msCompile"
},
{
"label": "Fab2ApprovalMKLink-User Secrets Init",
"command": "dotnet",

5
Fab2ApprovalMKLink/Fab2ApprovalMKLink.csproj
View File

@ -18,6 +18,11 @@
<PropertyGroup Condition="'$(TargetFramework)' == 'net8.0'">
<DefineConstants>NET8</DefineConstants>
</PropertyGroup>
<ItemGroup>
<AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleTo">
<_Parameter1>Fab2ApprovalTests</_Parameter1>
</AssemblyAttribute>
</ItemGroup>
<ItemGroup>
<PackageReference Include="Dapper.Contrib" Version="2.0.78" />
<PackageReference Include="Dapper" Version="2.1.44" />

2
Fab2ApprovalSystem/DMO/ECN_DMO.cs
View File

@ -390,7 +390,7 @@ public class ECN_DMO {
internal List<ECNCategory> GetCategories() {
List<ECNCategory> r = db.Query<ECNCategory>("ECNGetCategories", null, commandType: CommandType.StoredProcedure).ToList();
return r;
return r.OrderBy(l => l.CategoryName).ToList();
}
internal List<ECNArea> GetECNAreas() {

2
Fab2ApprovalSystem/EmailTemplates/TECNCancelled.txt
View File

@ -2,7 +2,7 @@
*****Please DO NOT reply to this email*****
<br/><br/>
{3}# {0} has been Cancelled. Please remove posted TECN from point of use. The cancellation date is {4}
Please review the cancelled TECN form in the attachment.
Please review comments below and ensure process has been returned to normal.
<br/><br/>
https://messa016ec.infineon.com/ECN/Edit?issueID={1}
<br/><br/>

2
Fab2ApprovalSystem/EmailTemplates/TECNReturnedToProcess.txt
View File

@ -2,7 +2,7 @@
*****Please DO NOT reply to this email*****
<br/><br/>
{3}# {0} has been returned to process. Please remove posted TECN from point of use. The returned to process date is {4}
Please review the returned to process TECN form in the attachment.
Please review comments below and ensure process has been returned to normal.
<br/><br/>
https://messa016ec.infineon.com/ECN/Edit?issueID={1}
<br/><br/>

0
azure-pipelines.yml → Fab2ApprovalSystem/pipelines.yml
View File

12
Fab2ApprovalTests/DMO/EngineeringChangeNoticeDMOTests.cs
View File

@ -85,6 +85,18 @@ public class EngineeringChangeNoticeDMOTests {
// int SubmitTECNExtensionDocument(int issueID, appSettings.UserId, int documentType, DateTime extensionDate);
// void TECNExtensionLog(int ecnNumber, DateTime extensionDate);
// void UpdateECNType(int ecnNumber, string ecnType);
// ECN InsertECN(ECN ecn)
// void UpdateECN(ECN ecn)
// ECN GetECN(int ecnNumber, out int isITAR, int userID)
// ECN GetECNForRead(int ecnNumber, out int isITAR, int userID)
// ECNPdf GetECNPdf(int ecnNumber)
ECNAffectedDeparmtent[] departments = ecnDMO.GetDepartments().ToArray();
ECNAffectedModule[] modules = ecnDMO.GetModules().ToArray();
ECNCategory[] categories = ecnDMO.GetCategories().ToArray();
ECNArea[] eCNAreas = ecnDMO.GetECNAreas().ToArray();
ECNTechnology[] eCNTechnologies = ecnDMO.GetECNTechnologies().ToArray();
ECNAcknowledgementTrainingBy[] eCNAcknowledgementTrainingBy = ecnDMO.GetECNAcknowledgementTrainingBy().ToArray();
ProductFamilies[] productFamilies = ecnDMO.GetProductFamilies().ToArray();
if (ecnDMO is null) { }
#pragma warning restore IDE0059
}