From cfe43360fc3bbb2888bd4cf39cdcc5eb4e6c9955 Mon Sep 17 00:00:00 2001 From: Mike Phares Date: Wed, 27 Dec 2023 12:29:02 -0700 Subject: [PATCH] IDE0200 --- .editorconfig | 9 +++++---- Instance/DlibDotNet.cs | 2 +- Map/Models/Stateless/MapLogic.cs | 2 +- Metadata-Query/MetadataQuery.cs | 2 +- Shared/Models/Stateless/Methods/FileHolder.cs | 2 +- Tests/UnitTestResize.cs | 2 +- TestsWithFaceRecognitionDotNet/UnitTestFace.cs | 2 +- 7 files changed, 11 insertions(+), 10 deletions(-) diff --git a/.editorconfig b/.editorconfig index 3dfc1d0..5ff0c05 100644 --- a/.editorconfig +++ b/.editorconfig @@ -88,21 +88,22 @@ dotnet_code_quality.CAXXXX.api_surface = private, internal dotnet_diagnostic.CA1825.severity = warning # CA1823: Avoid zero-length array allocations dotnet_diagnostic.CA1829.severity = warning # CA1829: Use Length/Count property instead of Count() when available dotnet_diagnostic.CA1834.severity = warning # CA1834: Consider using 'StringBuilder.Append(char)' when applicable -dotnet_diagnostic.CA1860.severity = error # CA1860: Prefer comparing 'Count' to 0 rather than using 'Any()', both for clarity and for performance +dotnet_diagnostic.CA1860.severity = warning # CA1860: Prefer comparing 'Count' to 0 rather than using 'Any()', both for clarity and for performance dotnet_diagnostic.CA1869.severity = none # CA1869: Avoid creating a new 'JsonSerializerOptions' instance for every serialization operation. Cache and reuse instances instead. dotnet_diagnostic.CA2254.severity = none # CA2254: The logging message template should not vary between calls to 'LoggerExtensions.LogInformation(ILogger, string?, params object?[])' dotnet_diagnostic.IDE0001.severity = warning # IDE0001: Simplify name dotnet_diagnostic.IDE0002.severity = warning # Simplify (member access) - System.Version.Equals("1", "2"); Version.Equals("1", "2"); dotnet_diagnostic.IDE0004.severity = warning # IDE0004: Cast is redundant. dotnet_diagnostic.IDE0005.severity = warning # Using directive is unnecessary -dotnet_diagnostic.IDE0028.severity = error # IDE0028: Collection initialization can be simplified +dotnet_diagnostic.IDE0028.severity = warning # IDE0028: Collection initialization can be simplified dotnet_diagnostic.IDE0031.severity = warning # Use null propagation (IDE0031) dotnet_diagnostic.IDE0047.severity = warning # IDE0047: Parentheses can be removed dotnet_diagnostic.IDE0049.severity = warning # Use language keywords instead of framework type names for type references (IDE0049) dotnet_diagnostic.IDE0060.severity = warning # IDE0060: Remove unused parameter +dotnet_diagnostic.IDE0200.severity = warning # IDE0200: Lambda expression can be removed [Map] dotnet_diagnostic.IDE0290.severity = none # Use primary constructor [Distance]csharp(IDE0290) -dotnet_diagnostic.IDE0300.severity = error # IDE0300: Collection initialization can be simplified -dotnet_diagnostic.IDE0301.severity = error #IDE0301: Collection initialization can be simplified +dotnet_diagnostic.IDE0300.severity = warning # IDE0300: Collection initialization can be simplified +dotnet_diagnostic.IDE0301.severity = warning #IDE0301: Collection initialization can be simplified dotnet_diagnostic.IDE0305.severity = none # IDE0305: Collection initialization can be simplified dotnet_naming_rule.abstract_method_should_be_pascal_case.severity = warning dotnet_naming_rule.abstract_method_should_be_pascal_case.style = pascal_case diff --git a/Instance/DlibDotNet.cs b/Instance/DlibDotNet.cs index 6a73758..4f24660 100644 --- a/Instance/DlibDotNet.cs +++ b/Instance/DlibDotNet.cs @@ -532,7 +532,7 @@ public partial class DlibDotNet foreach (string outputResolution in _Configuration.OutputResolutions) { total = 0; - outputResolutionHasNumber = outputResolution.Any(l => char.IsNumber(l)); + outputResolutionHasNumber = outputResolution.Any(char.IsNumber); (cResultsFullGroupDirectory, c2ResultsFullGroupDirectory, dResultsFullGroupDirectory, d2ResultsFullGroupDirectory) = GetResultsFullGroupDirectories(outputResolution); _Faces.Update(dResultsFullGroupDirectory); _Resize.Update(cResultsFullGroupDirectory); diff --git a/Map/Models/Stateless/MapLogic.cs b/Map/Models/Stateless/MapLogic.cs index a956cf8..713658b 100644 --- a/Map/Models/Stateless/MapLogic.cs +++ b/Map/Models/Stateless/MapLogic.cs @@ -67,7 +67,7 @@ internal abstract class MapLogic wholePercentages = IMapping.GetWholePercentages(configuration.FacesFileNameExtension, filePath); if (wholePercentages is null) continue; - if (!skipNotSkipDirectoriesAny || !checkDirectories.Any(l => filePath.FullName.StartsWith(l))) + if (!skipNotSkipDirectoriesAny || !checkDirectories.Any(filePath.FullName.StartsWith)) { if (!skipCollection.ContainsKey(filePath.Id.Value)) skipCollection.Add(filePath.Id.Value, []); diff --git a/Metadata-Query/MetadataQuery.cs b/Metadata-Query/MetadataQuery.cs index 057e3a8..4553338 100644 --- a/Metadata-Query/MetadataQuery.cs +++ b/Metadata-Query/MetadataQuery.cs @@ -127,4 +127,4 @@ public class MetadataQuery } } -} +} \ No newline at end of file diff --git a/Shared/Models/Stateless/Methods/FileHolder.cs b/Shared/Models/Stateless/Methods/FileHolder.cs index c909661..e30bedb 100644 --- a/Shared/Models/Stateless/Methods/FileHolder.cs +++ b/Shared/Models/Stateless/Methods/FileHolder.cs @@ -7,7 +7,7 @@ internal abstract class FileHolder { List results = []; foreach ((string _, string[] files) in collection) - results.AddRange(files.Select(l => IFileHolder.Get(l))); + results.AddRange(files.Select(IFileHolder.Get)); return results; } diff --git a/Tests/UnitTestResize.cs b/Tests/UnitTestResize.cs index 5208ac7..4c4d6ec 100644 --- a/Tests/UnitTestResize.cs +++ b/Tests/UnitTestResize.cs @@ -138,7 +138,7 @@ public class UnitTestResize int length = _PropertyConfiguration.RootDirectory.Length; string[] changesFrom = [nameof(A_Property)]; string outputResolution = _Configuration.OutputResolutions[0]; - bool outputResolutionHasNumber = outputResolution.Any(l => char.IsNumber(l)); + bool outputResolutionHasNumber = outputResolution.Any(char.IsNumber); (string cResultsFullGroupDirectory, _, _) = GetResultsFullGroupDirectories(outputResolution); (string aResultsFullGroupDirectory, string bResultsFullGroupDirectory) = GetResultsFullGroupDirectories(); Shared.Models.Methods.IBlurHasher blurHasher = new BlurHash.Models.C2_BlurHasher(_PropertyConfiguration); diff --git a/TestsWithFaceRecognitionDotNet/UnitTestFace.cs b/TestsWithFaceRecognitionDotNet/UnitTestFace.cs index 28e400e..c62ad91 100644 --- a/TestsWithFaceRecognitionDotNet/UnitTestFace.cs +++ b/TestsWithFaceRecognitionDotNet/UnitTestFace.cs @@ -211,7 +211,7 @@ public class UnitTestFace int length = _PropertyConfiguration.RootDirectory.Length; string[] changesFrom = [nameof(A_Property)]; string outputResolution = _Configuration.OutputResolutions[0]; - bool outputResolutionHasNumber = outputResolution.Any(l => char.IsNumber(l)); + bool outputResolutionHasNumber = outputResolution.Any(char.IsNumber); (string cResultsFullGroupDirectory, _, _) = GetResultsFullGroupDirectories(outputResolution); (string aResultsFullGroupDirectory, string bResultsFullGroupDirectory) = GetResultsFullGroupDirectories(); Shared.Models.Methods.IBlurHasher blurHasher = new BlurHash.Models.C2_BlurHasher(_PropertyConfiguration);