phares3757/open-insight
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merged PR 26784: Error Message buffer variable mismatch. Errors were being set to ErrorMsg and...

Browse Source 
Error Message buffer variable mismatch. Errors were being set to ErrorMsg and it needed to be set to ErrMsg. LoadSignatureReady was being set to false, but there were no cases to handle that false response with the variable ErrMsg not getting set.
This commit is contained in:
Ouellette Jonathan (CSC FI SPS MESLEO)
2025-09-24 15:57:32 +00:00
parent 40a7a5e5a1
commit f1a719d279
1 changed files with 17 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
LSL2/STPROC/SCAN_SERVICES.txt
View File

@ -1003,13 +1003,13 @@ Service ProcessScanData(ScanID, ScanJSON)
LoadStageReady = QA_Services('LoadSignatureReady', RDSNo, Username, WaferQty, LLSide, True$, Reactor) LoadStageReady = QA_Services('LoadSignatureReady', RDSNo, Username, WaferQty, LLSide, True$, Reactor)
If (LoadStageReady NE True$) then If (LoadStageReady NE True$) then
// Why is it not ready? // Why is it not ready?
ErrorMsg = Error_Services('GetMessage') ErrMsg = Error_Services('GetMessage')
Begin Case Begin Case
Case IndexC(ErrorMsg, 'supplement', 1) Case IndexC(ErrMsg, 'supplement', 1)
// Clear the error to return a JSON payload and handle the acknowledgements. // Clear the error to return a JSON payload and handle the acknowledgements.
Error_Services('Clear') Error_Services('Clear')
Scan_Services('AddNotAcceptableReason', ErrorMsg) Scan_Services('AddNotAcceptableReason', ErrMsg)
Case IndexC(ErrorMsg, 'ROTR', 1) Case IndexC(ErrMsg, 'ROTR', 1)
ROTRBlock = Database_Services('ReadDataColumn', 'REACTOR', Reactor, REACTOR_ROTR_STATUS$, True$, 0, False$) ROTRBlock = Database_Services('ReadDataColumn', 'REACTOR', Reactor, REACTOR_ROTR_STATUS$, True$, 0, False$)
ROTRBlockReason = Database_Services('ReadDataColumn', 'REACTOR', Reactor, REACTOR_ROTR_STATUS_REASON$, True$, 0, False$) ROTRBlockReason = Database_Services('ReadDataColumn', 'REACTOR', Reactor, REACTOR_ROTR_STATUS_REASON$, True$, 0, False$)
ROTREnabled = Database_Services('ReadDataColumn', 'REACTOR', Reactor, REACTOR_ENABLE_ROTR$, True$, 0, False$) ROTREnabled = Database_Services('ReadDataColumn', 'REACTOR', Reactor, REACTOR_ENABLE_ROTR$, True$, 0, False$)
@ -1029,11 +1029,11 @@ Service ProcessScanData(ScanID, ScanJSON)
end end
end else end else
// Why is it not ready? // Why is it not ready?
ErrorMsg = Error_Services('GetMessage') ErrMsg = Error_Services('GetMessage')
Begin Case Begin Case
Case IndexC(ErrorMsg, 'supplement', 1) Case IndexC(ErrMsg, 'supplement', 1)
Error_Services('Clear') Error_Services('Clear')
Scan_Services('AddNotAcceptableReason', ErrorMsg) Scan_Services('AddNotAcceptableReason', ErrMsg)
End Case End Case
end end
end else end else
@ -1079,13 +1079,13 @@ Service ProcessScanData(ScanID, ScanJSON)
LoadStageReady = QA_Services('LoadSignatureReady', RDSNo, Username, WaferQty, LLSide) LoadStageReady = QA_Services('LoadSignatureReady', RDSNo, Username, WaferQty, LLSide)
If (LoadStageReady NE True$) then If (LoadStageReady NE True$) then
// Why is it not ready? // Why is it not ready?
ErrorMsg = Error_Services('GetMessage') ErrMsg = Error_Services('GetMessage')
Begin Case Begin Case
Case IndexC(ErrorMsg, 'supplement', 1) Case IndexC(ErrMsg, 'supplement', 1)
// Clear the error to return a JSON payload and handle the acknowledgements. // Clear the error to return a JSON payload and handle the acknowledgements.
Error_Services('Clear') Error_Services('Clear')
Scan_Services('AddNotAcceptableReason', ErrorMsg) Scan_Services('AddNotAcceptableReason', ErrMsg)
Case IndexC(ErrorMsg, 'ROTR', 1) Case IndexC(ErrMsg, 'ROTR', 1)
ROTRBlock = Database_Services('ReadDataColumn', 'REACTOR', Reactor, REACTOR_ROTR_STATUS$, True$, 0, False$) ROTRBlock = Database_Services('ReadDataColumn', 'REACTOR', Reactor, REACTOR_ROTR_STATUS$, True$, 0, False$)
ROTRBlockReason = Database_Services('ReadDataColumn', 'REACTOR', Reactor, REACTOR_ROTR_STATUS_REASON$, True$, 0, False$) ROTRBlockReason = Database_Services('ReadDataColumn', 'REACTOR', Reactor, REACTOR_ROTR_STATUS_REASON$, True$, 0, False$)
ROTREnabled = Database_Services('ReadDataColumn', 'REACTOR', Reactor, REACTOR_ENABLE_ROTR$, True$, 0, False$) ROTREnabled = Database_Services('ReadDataColumn', 'REACTOR', Reactor, REACTOR_ENABLE_ROTR$, True$, 0, False$)
@ -1110,8 +1110,8 @@ Service ProcessScanData(ScanID, ScanJSON)
Scan_Services('AddNotAcceptableReason', 'The LWI stage engineering instructions must be acknowledged before the load operation can be signed.') Scan_Services('AddNotAcceptableReason', 'The LWI stage engineering instructions must be acknowledged before the load operation can be signed.')
end end
end else end else
ErrorMessage = 'RDS layer parameters must be reviewed for accuracy and acknowledged before the load operation can be signed.' ErrMsg = 'RDS layer parameters must be reviewed for accuracy and acknowledged before the load operation can be signed.'
Scan_Services('AddNotAcceptableReason', ErrorMessage) Scan_Services('AddNotAcceptableReason', ErrMsg)
end end
end else end else
ErrMsg = 'Scanned tool ':ScanTool:' does not match the scheduled tool ':SchedTool:'. (':RDSNo:')' ErrMsg = 'Scanned tool ':ScanTool:' does not match the scheduled tool ':SchedTool:'. (':RDSNo:')'
@ -1138,11 +1138,11 @@ Service ProcessScanData(ScanID, ScanJSON)
UnloadStageReady = QA_Services('UnloadSignatureReady', RDSNo, Username, Reactor) UnloadStageReady = QA_Services('UnloadSignatureReady', RDSNo, Username, Reactor)
If Not(UnloadStageReady) then If Not(UnloadStageReady) then
// Why is it not ready? // Why is it not ready?
ErrorMsg = Error_Services('GetMessage') ErrMsg = Error_Services('GetMessage')
Begin Case Begin Case
Case IndexC(ErrorMsg, 'supplement', 1) Case IndexC(ErrMsg, 'supplement', 1)
Error_Services('Clear') Error_Services('Clear')
Scan_Services('AddNotAcceptableReason', ErrorMsg) Scan_Services('AddNotAcceptableReason', ErrMsg)
Case Otherwise$ Case Otherwise$
// Keep error on Error_Services stack and return 400 level error. // Keep error on Error_Services stack and return 400 level error.
End Case End Case
@ -2421,3 +2421,4 @@ return