From 0475533f8e66ab72e406ed41a3ce1fcebceba7fe Mon Sep 17 00:00:00 2001
From: Mike Phares <mike.phares@infineon.com>
Date: Mon, 18 Nov 2024 14:30:19 -0700
Subject: [PATCH] FlagDuplicates CA1510 Complete

---
 Adaptation/.editorconfig                      |  3 ++-
 Adaptation/.vscode/tasks.json                 |  2 +-
 .../FileHandlers/OpenInsight/FromIQS.cs       | 23 ++++++++++---------
 Adaptation/FileHandlers/RsM/ProcessData.cs    |  4 ++--
 4 files changed, 17 insertions(+), 15 deletions(-)

diff --git a/Adaptation/.editorconfig b/Adaptation/.editorconfig
index 69ecc38..d6755a0 100644
--- a/Adaptation/.editorconfig
+++ b/Adaptation/.editorconfig
@@ -92,8 +92,9 @@ csharp_using_directive_placement = outside_namespace
 dotnet_code_quality_unused_parameters = all
 dotnet_code_quality_unused_parameters = non_public # IDE0060: Remove unused parameter
 dotnet_code_quality.CAXXXX.api_surface = private, internal
+dotnet_diagnostic.CA1510.severity = none # CA1510: Use 'ArgumentNullException.ThrowIfNull' instead of explicitly throwing a new exception instance
 dotnet_diagnostic.CA1816.severity = none # CA1816: Call GC.SuppressFinalize correctly
-dotnet_diagnostic.CA1825.severity = warning # CA1823: Avoid zero-length array allocations
+dotnet_diagnostic.CA1825.severity = warning # CA1825: Avoid zero-length array allocations
 dotnet_diagnostic.CA1829.severity = warning # CA1829: Use Length/Count property instead of Count() when available
 dotnet_diagnostic.CA1834.severity = warning # CA1834: Consider using 'StringBuilder.Append(char)' when applicable
 dotnet_diagnostic.CA1846.severity = none # CA1846: Prefer AsSpan over Substring
diff --git a/Adaptation/.vscode/tasks.json b/Adaptation/.vscode/tasks.json
index b867de1..181dcab 100644
--- a/Adaptation/.vscode/tasks.json
+++ b/Adaptation/.vscode/tasks.json
@@ -78,7 +78,7 @@
             "args": [
                 "/target:Build",
                 "/restore:True",
-                "/p:RestoreSources=https://artifactory.intra.infineon.com/artifactory/api/nuget/ngt-fi-package-main-vir/%3Bhttps://packagemanagement.eu.infineon.com:4430/api/v2/%3Bhttps://tfs.intra.infineon.com/tfs/ManufacturingIT/_packaging/eaf/nuget/v3/index.json%3Bhttps://tfs.intra.infineon.com/tfs/FactoryIntegration/_packaging/EAF%40Local/nuget/v3/index.json%3Bhttps://api.nuget.org/v3/index.json",
+                "/p:RestoreSources=https://artifactory.intra.infineon.com/artifactory/api/nuget/ngt-fi-package-main-vir/%3Bhttps://packagemanagement.eu.infineon.com:4430/api/v2/%3Bhttps://tfs.intra.infineon.com/tfs/FactoryIntegration/_packaging/EAF/nuget/v3/index.json%3Bhttps://tfs.intra.infineon.com/tfs/FactoryIntegration/_packaging/EAF%40Local/nuget/v3/index.json%3Bhttps://api.nuget.org/v3/index.json",
                 "/detailedsummary",
                 "/consoleloggerparameters:PerformanceSummary;ErrorsOnly;",
                 "/property:Configuration=Debug;TargetFrameworkVersion=v4.8",
diff --git a/Adaptation/FileHandlers/OpenInsight/FromIQS.cs b/Adaptation/FileHandlers/OpenInsight/FromIQS.cs
index 6bf4b73..69fec60 100644
--- a/Adaptation/FileHandlers/OpenInsight/FromIQS.cs
+++ b/Adaptation/FileHandlers/OpenInsight/FromIQS.cs
@@ -244,14 +244,9 @@ public class FromIQS
             }
             if (collection.Count > 0)
             {
-                try
-                {
-                    string commandText = GetCommandText(collection);
-                    File.WriteAllText("D:/.sql", commandText);
-                    _ = ExecuteNonQuery(connectionString, commandText);
-                }
-                catch (Exception)
-                { }
+                string commandText = GetCommandText(collection);
+                File.WriteAllText("D:/.sql", commandText);
+                _ = ExecuteNonQuery(connectionString, commandText);
             }
         }
     }
@@ -271,9 +266,15 @@ public class FromIQS
         else
             dateTime = logistics.DateTimeFromSequence;
         commandText = GetCommandText(dateTime);
-        stringBuilder = GetForJsonPath(connectionString, commandText);
-        if (stringBuilder.Length > 0)
-            FlagDuplicates(connectionString, stringBuilder.ToString());
+        try
+        {
+            stringBuilder = GetForJsonPath(connectionString, commandText);
+            if (stringBuilder.Length > 0)
+                FlagDuplicates(connectionString, stringBuilder.ToString());
+        }
+        catch (Exception)
+        { stringBuilder = new(); }
+        _ = stringBuilder.Clear();
         commandText = GetCommandText(logistics, description, dateTime.ToString("yyyy-MM-dd HH:mm:ss"), subGroupId: null);
         for (short i = 0; i < short.MaxValue; i++)
         {
diff --git a/Adaptation/FileHandlers/RsM/ProcessData.cs b/Adaptation/FileHandlers/RsM/ProcessData.cs
index c69d3b9..305bdc8 100644
--- a/Adaptation/FileHandlers/RsM/ProcessData.cs
+++ b/Adaptation/FileHandlers/RsM/ProcessData.cs
@@ -339,10 +339,10 @@ public class ProcessData : IProcessData
         return result;
     }
 
-#pragma warning disable IDE0060
     private void Parse(IFileRead fileRead, Logistics logistics, List<FileInfo> fileInfoCollection)
-#pragma warning restore IDE0060
     {
+        if (fileRead is null)
+            throw new ArgumentNullException(nameof(fileRead));
         Lot = "LotID";
         Detail detail;
         string[] segments;