Refactor JSON deserialization in ProcessData classes and improve error handling
This commit is contained in:
@ -143,7 +143,7 @@ function updateRecordCoD(b, r, t, c, e, w, workItem, highestTotalStoryPoints, da
|
||||
let businessValue = workItem.BusinessValue;
|
||||
let timeCriticality = workItem.TimeCriticality;
|
||||
let riskReductionMinusOpportunityEnablement = workItem.RiskReductionMinusOpportunityEnablement;
|
||||
let weightedShortestJobFirst = workItem.WeightedShortestJobFirst == undefined ? null : workItem.WeightedShortestJobFirst.toFixed(2);
|
||||
let weightedShortestJobFirst = workItem.WeightedShortestJobFirst == undefined ? ' ' : workItem.WeightedShortestJobFirst.toFixed(2);
|
||||
workItem.CumulativeStoryPoints = ' ';
|
||||
workItem.TotalStoryPoints = totalStoryPoints + ' User Story Point(s)';
|
||||
workItem.AbsoluteDelta = data.Effort == undefined || data.Effort.FibonacciAverage == undefined || totalStoryPoints == undefined || totalStoryPoints === 0 ? ' ' : round(Math.abs(data.Effort.FibonacciAverage - ((totalStoryPoints / highestTotalStoryPoints) * 5)), 1);
|
||||
@ -159,15 +159,19 @@ function updateRecordCoD(b, r, t, c, e, w, workItem, highestTotalStoryPoints, da
|
||||
workItem.TimeCriticalityNotifications = data.TimeCriticality == undefined ? ' ' : getNotifications(t, data.TimeCriticality);
|
||||
workItem.RiskReductionMinusOpportunityEnablementNotifications = data.RiskReductionOpportunityEnablement == undefined ? ' ' : getNotifications(r, data.RiskReductionOpportunityEnablement);
|
||||
workItem.SortOrder = data.SortOrder == undefined ? 0 : data.SortOrder;
|
||||
let check = effort == workItem.Effort
|
||||
&& businessValue === workItem.BusinessValue
|
||||
&& timeCriticality === workItem.TimeCriticality
|
||||
&& riskReductionMinusOpportunityEnablement === workItem.RiskReductionMinusOpportunityEnablement;
|
||||
if (check && weightedShortestJobFirst == workItem.WeightedShortestJobFirst) {
|
||||
if (effort == undefined || businessValue == undefined || timeCriticality == undefined || riskReductionMinusOpportunityEnablement || weightedShortestJobFirst == undefined) {
|
||||
workItem.api = '';
|
||||
} else {
|
||||
workItem.api = `
|
||||
### Work Item Patch ${check} WSJF ${workItem.Id} ${weightedShortestJobFirst} != ${workItem.WeightedShortestJobFirst}
|
||||
}
|
||||
else {
|
||||
let check = effort === workItem.Effort
|
||||
&& businessValue === workItem.BusinessValue
|
||||
&& timeCriticality === workItem.TimeCriticality
|
||||
&& riskReductionMinusOpportunityEnablement === workItem.RiskReductionMinusOpportunityEnablement;
|
||||
if (check && weightedShortestJobFirst == workItem.WeightedShortestJobFirst) {
|
||||
workItem.api = '';
|
||||
} else {
|
||||
workItem.api = `
|
||||
### Work Item Patch ${check} WSJF ${workItem.Id} ${effort}:${workItem.Effort}; ${businessValue}:${workItem.BusinessValue}; ${timeCriticality}:${workItem.TimeCriticality}; ${riskReductionMinusOpportunityEnablement}:${workItem.RiskReductionMinusOpportunityEnablement}; ${weightedShortestJobFirst}:${workItem.WeightedShortestJobFirst};
|
||||
|
||||
patch {{Factory-Integration}}/_apis/wit/workitems/${workItem.Id}?api-version=7.0
|
||||
Authorization: Basic {{PAT}}
|
||||
@ -178,44 +182,45 @@ Content-Type: application/json-patch+json
|
||||
"op": "replace",
|
||||
"path": "/fields/Microsoft.VSTS.Common.BusinessValue",
|
||||
"value": "${workItem.BusinessValue}"
|
||||
},
|
||||
{
|
||||
"op": "replace",
|
||||
"path": "/fields/Microsoft.VSTS.Scheduling.Effort",
|
||||
"value": "${workItem.Effort}"
|
||||
},
|
||||
{
|
||||
"op": "replace",
|
||||
"path": "/fields/Custom.RRminusOE",
|
||||
"value": "${workItem.RiskReductionMinusOpportunityEnablement}"
|
||||
},
|
||||
{
|
||||
"op": "replace",
|
||||
"path": "/fields/Microsoft.VSTS.Common.TimeCriticality",
|
||||
},
|
||||
{
|
||||
"op": "replace",
|
||||
"path": "/fields/Microsoft.VSTS.Scheduling.Effort",
|
||||
"value": "${workItem.Effort}"
|
||||
},
|
||||
{
|
||||
"op": "replace",
|
||||
"path": "/fields/Custom.RRminusOE",
|
||||
"value": "${workItem.RiskReductionMinusOpportunityEnablement}"
|
||||
},
|
||||
{
|
||||
"op": "replace",
|
||||
"path": "/fields/Microsoft.VSTS.Common.TimeCriticality",
|
||||
"value": "${workItem.TimeCriticality}"
|
||||
},
|
||||
{
|
||||
"op": "replace",
|
||||
},
|
||||
{
|
||||
"op": "replace",
|
||||
"path": "/fields/Custom.WSJF",
|
||||
"value": "${workItem.WeightedShortestJobFirst}"
|
||||
},
|
||||
{
|
||||
"op": "replace",
|
||||
"path": "/fields/Custom.WSJFFib",
|
||||
"value": "${workItem.WeightedShortestJobFirst}"
|
||||
}
|
||||
]
|
||||
|
||||
HTTP 200
|
||||
[Asserts]
|
||||
header "Content-Type" == "application/json; charset=utf-8; api-version=7.0"
|
||||
jsonpath "$.id" == ${workItem.Id}
|
||||
jsonpath "$.fields['Microsoft.VSTS.Common.BusinessValue']" == ${workItem.BusinessValue}
|
||||
jsonpath "$.fields['Microsoft.VSTS.Scheduling.Effort']" == ${workItem.Effort}
|
||||
jsonpath "$.fields['Custom.RRminusOE']" == ${workItem.RiskReductionMinusOpportunityEnablement}
|
||||
jsonpath "$.fields['Microsoft.VSTS.Common.TimeCriticality']" == ${workItem.TimeCriticality}
|
||||
jsonpath "$.fields['Custom.WSJF']" == ${workItem.WeightedShortestJobFirst}
|
||||
jsonpath "$.fields['Custom.WSJFFib']" == ${workItem.WeightedShortestJobFirst}`;
|
||||
},
|
||||
{
|
||||
"op": "replace",
|
||||
"path": "/fields/Custom.WSJFFib",
|
||||
"value": "${workItem.WeightedShortestJobFirst}"
|
||||
}
|
||||
]
|
||||
|
||||
HTTP 200
|
||||
[Asserts]
|
||||
header "Content-Type" == "application/json; charset=utf-8; api-version=7.0"
|
||||
jsonpath "$.id" == ${workItem.Id}
|
||||
jsonpath "$.fields['Microsoft.VSTS.Common.BusinessValue']" == ${workItem.BusinessValue}
|
||||
jsonpath "$.fields['Microsoft.VSTS.Scheduling.Effort']" == ${workItem.Effort}
|
||||
jsonpath "$.fields['Custom.RRminusOE']" == ${workItem.RiskReductionMinusOpportunityEnablement}
|
||||
jsonpath "$.fields['Microsoft.VSTS.Common.TimeCriticality']" == ${workItem.TimeCriticality}
|
||||
jsonpath "$.fields['Custom.WSJF']" == ${workItem.WeightedShortestJobFirst}
|
||||
jsonpath "$.fields['Custom.WSJFFib']" == ${workItem.WeightedShortestJobFirst}`;
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user