phares3757/mesa-fab-approval
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed MRB Actions Convert bug

Browse Source
This commit is contained in:
Chase Tucker 2025-01-31 08:50:54 -07:00
parent f0df620dc9
commit 40e7a3f8e0
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
MesaFabApproval.API/Services/MRBService.cs
View File

@ -852,8 +852,8 @@ public class MRBService : IMRBService {
convertToPart += partStr; convertToPart += partStr;
} }
dt.Rows.Add(action.Action, convertFromCustomer, convertFromPart, action.Quantity.ToString(), dt.Rows.Add(action.Action, convertFromCustomer, convertFromPart, action.LotNumber,
convertToCustomer, convertToPart, action.Quantity.ToString(), convertToCustomer, convertToPart,
DateTimeUtilities.GetDateAsStringMinDefault(action.AssignedDate), DateTimeUtilities.GetDateAsStringMinDefault(action.AssignedDate),
DateTimeUtilities.GetDateAsStringMaxDefault(action.CompletedDate), DateTimeUtilities.GetDateAsStringMaxDefault(action.CompletedDate),
action.CompletedByUser is null ? "" : action.CompletedByUser.GetFullName()); action.CompletedByUser is null ? "" : action.CompletedByUser.GetFullName());

7
MesaFabApproval.Client/Pages/Components/MRBActionForm.razor
View File

@ -215,9 +215,7 @@
bool actionIsValid = mrbAction.Action.Equals("Block") || mrbAction.Action.Equals("Convert") || bool actionIsValid = mrbAction.Action.Equals("Block") || mrbAction.Action.Equals("Convert") ||
mrbAction.Action.Equals("Other") || mrbAction.Action.Equals("Recall") || mrbAction.Action.Equals("Scrap") || mrbAction.Action.Equals("Other") || mrbAction.Action.Equals("Recall") || mrbAction.Action.Equals("Scrap") ||
mrbAction.Action.Equals("Unblock") || mrbAction.Action.Equals("Waiver"); mrbAction.Action.Equals("Unblock") || mrbAction.Action.Equals("Waiver");
actionIsValid = actionIsValid && !string.IsNullOrWhiteSpace(mrbAction.Customer) && actionIsValid = actionIsValid && !string.IsNullOrWhiteSpace(mrbAction.LotNumber);
!string.IsNullOrWhiteSpace(mrbAction.PartNumber) &&
!string.IsNullOrWhiteSpace(mrbAction.LotNumber);
actionIsValid = actionIsValid && mrbAction.Quantity > 0; actionIsValid = actionIsValid && mrbAction.Quantity > 0;
if (mrbAction.Action.Equals("Convert", StringComparison.InvariantCultureIgnoreCase)) { if (mrbAction.Action.Equals("Convert", StringComparison.InvariantCultureIgnoreCase)) {
@ -225,6 +223,9 @@
!string.IsNullOrWhiteSpace(convertFromPart) && !string.IsNullOrWhiteSpace(convertFromPart) &&
!string.IsNullOrWhiteSpace(convertToCustomer) && !string.IsNullOrWhiteSpace(convertToCustomer) &&
!string.IsNullOrWhiteSpace(convertToPart); !string.IsNullOrWhiteSpace(convertToPart);
} else {
actionIsValid = actionIsValid && !string.IsNullOrWhiteSpace(mrbAction.Customer) &&
!string.IsNullOrWhiteSpace(mrbAction.PartNumber);
} }
if (mrbAction.Action.Equals("Scrap", StringComparison.InvariantCultureIgnoreCase)) if (mrbAction.Action.Equals("Scrap", StringComparison.InvariantCultureIgnoreCase))