diff --git a/alerting/provider/discord/discord.go b/alerting/provider/discord/discord.go index 94574e4f..33e279a5 100644 --- a/alerting/provider/discord/discord.go +++ b/alerting/provider/discord/discord.go @@ -48,10 +48,10 @@ func (provider *AlertProvider) buildRequestBody(endpoint *core.Endpoint, alert * var message, results string var colorCode int if resolved { - message = fmt.Sprintf("An alert for **%s** has been resolved after passing successfully %d time(s) in a row", endpoint.Name, alert.SuccessThreshold) + message = fmt.Sprintf("An alert for **%s** has been resolved after passing successfully %d time(s) in a row", endpoint.DisplayName(), alert.SuccessThreshold) colorCode = 3066993 } else { - message = fmt.Sprintf("An alert for **%s** has been triggered due to having failed %d time(s) in a row", endpoint.Name, alert.FailureThreshold) + message = fmt.Sprintf("An alert for **%s** has been triggered due to having failed %d time(s) in a row", endpoint.DisplayName(), alert.FailureThreshold) colorCode = 15158332 } for _, conditionResult := range result.ConditionResults { diff --git a/alerting/provider/email/email.go b/alerting/provider/email/email.go index 721eca08..03277aa1 100644 --- a/alerting/provider/email/email.go +++ b/alerting/provider/email/email.go @@ -43,11 +43,11 @@ func (provider *AlertProvider) Send(endpoint *core.Endpoint, alert *alert.Alert, func (provider *AlertProvider) buildMessageSubjectAndBody(endpoint *core.Endpoint, alert *alert.Alert, result *core.Result, resolved bool) (string, string) { var subject, message, results string if resolved { - subject = fmt.Sprintf("[%s] Alert resolved", endpoint.Name) - message = fmt.Sprintf("An alert for %s has been resolved after passing successfully %d time(s) in a row", endpoint.Name, alert.SuccessThreshold) + subject = fmt.Sprintf("[%s] Alert resolved", endpoint.DisplayName()) + message = fmt.Sprintf("An alert for %s has been resolved after passing successfully %d time(s) in a row", endpoint.DisplayName(), alert.SuccessThreshold) } else { - subject = fmt.Sprintf("[%s] Alert triggered", endpoint.Name) - message = fmt.Sprintf("An alert for %s has been triggered due to having failed %d time(s) in a row", endpoint.Name, alert.FailureThreshold) + subject = fmt.Sprintf("[%s] Alert triggered", endpoint.DisplayName()) + message = fmt.Sprintf("An alert for %s has been triggered due to having failed %d time(s) in a row", endpoint.DisplayName(), alert.FailureThreshold) } for _, conditionResult := range result.ConditionResults { var prefix string diff --git a/alerting/provider/mattermost/mattermost.go b/alerting/provider/mattermost/mattermost.go index 066ced72..964aefc0 100644 --- a/alerting/provider/mattermost/mattermost.go +++ b/alerting/provider/mattermost/mattermost.go @@ -53,10 +53,10 @@ func (provider *AlertProvider) Send(endpoint *core.Endpoint, alert *alert.Alert, func (provider *AlertProvider) buildRequestBody(endpoint *core.Endpoint, alert *alert.Alert, result *core.Result, resolved bool) string { var message, color string if resolved { - message = fmt.Sprintf("An alert for *%s* has been resolved after passing successfully %d time(s) in a row", endpoint.Name, alert.SuccessThreshold) + message = fmt.Sprintf("An alert for *%s* has been resolved after passing successfully %d time(s) in a row", endpoint.DisplayName(), alert.SuccessThreshold) color = "#36A64F" } else { - message = fmt.Sprintf("An alert for *%s* has been triggered due to having failed %d time(s) in a row", endpoint.Name, alert.FailureThreshold) + message = fmt.Sprintf("An alert for *%s* has been triggered due to having failed %d time(s) in a row", endpoint.DisplayName(), alert.FailureThreshold) color = "#DD0000" } var results string diff --git a/alerting/provider/messagebird/messagebird.go b/alerting/provider/messagebird/messagebird.go index 1bcfbf7a..6dc10c0a 100644 --- a/alerting/provider/messagebird/messagebird.go +++ b/alerting/provider/messagebird/messagebird.go @@ -55,9 +55,9 @@ func (provider *AlertProvider) Send(endpoint *core.Endpoint, alert *alert.Alert, func (provider *AlertProvider) buildRequestBody(endpoint *core.Endpoint, alert *alert.Alert, result *core.Result, resolved bool) string { var message string if resolved { - message = fmt.Sprintf("RESOLVED: %s - %s", endpoint.Name, alert.GetDescription()) + message = fmt.Sprintf("RESOLVED: %s - %s", endpoint.DisplayName(), alert.GetDescription()) } else { - message = fmt.Sprintf("TRIGGERED: %s - %s", endpoint.Name, alert.GetDescription()) + message = fmt.Sprintf("TRIGGERED: %s - %s", endpoint.DisplayName(), alert.GetDescription()) } return fmt.Sprintf(`{ "originator": "%s", diff --git a/alerting/provider/opsgenie/opsgenie.go b/alerting/provider/opsgenie/opsgenie.go index a4b5746b..dd98d707 100644 --- a/alerting/provider/opsgenie/opsgenie.go +++ b/alerting/provider/opsgenie/opsgenie.go @@ -120,10 +120,10 @@ func (provider *AlertProvider) buildCreateRequestBody(endpoint *core.Endpoint, a var message, description, results string if resolved { message = fmt.Sprintf("RESOLVED: %s - %s", endpoint.Name, alert.GetDescription()) - description = fmt.Sprintf("An alert for *%s* has been resolved after passing successfully %d time(s) in a row", endpoint.Name, alert.SuccessThreshold) + description = fmt.Sprintf("An alert for *%s* has been resolved after passing successfully %d time(s) in a row", endpoint.DisplayName(), alert.SuccessThreshold) } else { message = fmt.Sprintf("%s - %s", endpoint.Name, alert.GetDescription()) - description = fmt.Sprintf("An alert for *%s* has been triggered due to having failed %d time(s) in a row", endpoint.Name, alert.FailureThreshold) + description = fmt.Sprintf("An alert for *%s* has been triggered due to having failed %d time(s) in a row", endpoint.DisplayName(), alert.FailureThreshold) } if endpoint.Group != "" { message = fmt.Sprintf("[%s] %s", endpoint.Group, message) diff --git a/alerting/provider/opsgenie/opsgenie_test.go b/alerting/provider/opsgenie/opsgenie_test.go index d6b9cd95..244fac92 100644 --- a/alerting/provider/opsgenie/opsgenie_test.go +++ b/alerting/provider/opsgenie/opsgenie_test.go @@ -155,7 +155,7 @@ func TestAlertProvider_buildCreateRequestBody(t *testing.T) { FailureThreshold: 3, }, Endpoint: &core.Endpoint{ - Name: "my supper app", + Name: "my super app", }, Result: &core.Result{ ConditionResults: []*core.ConditionResult{ @@ -171,16 +171,14 @@ func TestAlertProvider_buildCreateRequestBody(t *testing.T) { }, Resolved: false, want: alertCreateRequest{ - Message: "my supper app - " + description, - Priority: "P1", - Source: "gatus", - Entity: "gatus-my-supper-app", - Alias: "gatus-healthcheck-my-supper-app", - Description: "An alert for *my supper app* has been triggered due to having failed 3 time(s) in a row\n" + - "▣ - `[STATUS] == 200`\n" + - "▢ - `[BODY] == OK`\n", - Tags: nil, - Details: map[string]string{}, + Message: "my super app - " + description, + Priority: "P1", + Source: "gatus", + Entity: "gatus-my-super-app", + Alias: "gatus-healthcheck-my-super-app", + Description: "An alert for *my super app* has been triggered due to having failed 3 time(s) in a row\n▣ - `[STATUS] == 200`\n▢ - `[BODY] == OK`\n", + Tags: nil, + Details: map[string]string{}, }, }, { @@ -209,15 +207,14 @@ func TestAlertProvider_buildCreateRequestBody(t *testing.T) { }, Resolved: true, want: alertCreateRequest{ - Message: "RESOLVED: my mega app - " + description, - Priority: "P5", - Source: "gatus-hc", - Entity: "oompa-my-mega-app", - Alias: "loompa-my-mega-app", - Description: "An alert for *my mega app* has been resolved after passing successfully 4 time(s) in a row\n" + - "▣ - `[STATUS] == 200`\n", - Tags: []string{"do-ba-dee-doo"}, - Details: map[string]string{}, + Message: "RESOLVED: my mega app - " + description, + Priority: "P5", + Source: "gatus-hc", + Entity: "oompa-my-mega-app", + Alias: "loompa-my-mega-app", + Description: "An alert for *my mega app* has been resolved after passing successfully 4 time(s) in a row\n▣ - `[STATUS] == 200`\n", + Tags: []string{"do-ba-dee-doo"}, + Details: map[string]string{}, }, }, { @@ -248,14 +245,13 @@ func TestAlertProvider_buildCreateRequestBody(t *testing.T) { }, Resolved: false, want: alertCreateRequest{ - Message: "[end game] my app - " + description, - Priority: "P1", - Source: "gatus", - Entity: "gatus-end-game-my-app", - Alias: "gatus-healthcheck-end-game-my-app", - Description: "An alert for *my app* has been triggered due to having failed 6 time(s) in a row\n" + - "▢ - `[STATUS] == 200`\n", - Tags: []string{"foo"}, + Message: "[end game] my app - " + description, + Priority: "P1", + Source: "gatus", + Entity: "gatus-end-game-my-app", + Alias: "gatus-healthcheck-end-game-my-app", + Description: "An alert for *end game/my app* has been triggered due to having failed 6 time(s) in a row\n▢ - `[STATUS] == 200`\n", + Tags: []string{"foo"}, Details: map[string]string{ "endpoint:url": "https://my.go/app", "endpoint:group": "end game", diff --git a/alerting/provider/pagerduty/pagerduty.go b/alerting/provider/pagerduty/pagerduty.go index b009bfab..a1f790fb 100644 --- a/alerting/provider/pagerduty/pagerduty.go +++ b/alerting/provider/pagerduty/pagerduty.go @@ -90,11 +90,11 @@ func (provider *AlertProvider) Send(endpoint *core.Endpoint, alert *alert.Alert, func (provider *AlertProvider) buildRequestBody(endpoint *core.Endpoint, alert *alert.Alert, result *core.Result, resolved bool) string { var message, eventAction, resolveKey string if resolved { - message = fmt.Sprintf("RESOLVED: %s - %s", endpoint.Name, alert.GetDescription()) + message = fmt.Sprintf("RESOLVED: %s - %s", endpoint.DisplayName(), alert.GetDescription()) eventAction = "resolve" resolveKey = alert.ResolveKey } else { - message = fmt.Sprintf("TRIGGERED: %s - %s", endpoint.Name, alert.GetDescription()) + message = fmt.Sprintf("TRIGGERED: %s - %s", endpoint.DisplayName(), alert.GetDescription()) eventAction = "trigger" resolveKey = "" } diff --git a/alerting/provider/slack/slack.go b/alerting/provider/slack/slack.go index d82c50a5..e48cf0f6 100644 --- a/alerting/provider/slack/slack.go +++ b/alerting/provider/slack/slack.go @@ -47,10 +47,10 @@ func (provider *AlertProvider) Send(endpoint *core.Endpoint, alert *alert.Alert, func (provider *AlertProvider) buildRequestBody(endpoint *core.Endpoint, alert *alert.Alert, result *core.Result, resolved bool) string { var message, color, results string if resolved { - message = fmt.Sprintf("An alert for *%s* has been resolved after passing successfully %d time(s) in a row", endpoint.Name, alert.SuccessThreshold) + message = fmt.Sprintf("An alert for *%s* has been resolved after passing successfully %d time(s) in a row", endpoint.DisplayName(), alert.SuccessThreshold) color = "#36A64F" } else { - message = fmt.Sprintf("An alert for *%s* has been triggered due to having failed %d time(s) in a row", endpoint.Name, alert.FailureThreshold) + message = fmt.Sprintf("An alert for *%s* has been triggered due to having failed %d time(s) in a row", endpoint.DisplayName(), alert.FailureThreshold) color = "#DD0000" } for _, conditionResult := range result.ConditionResults { diff --git a/alerting/provider/slack/slack_test.go b/alerting/provider/slack/slack_test.go index 7dd04bdc..ddc7efaa 100644 --- a/alerting/provider/slack/slack_test.go +++ b/alerting/provider/slack/slack_test.go @@ -16,7 +16,7 @@ func TestAlertProvider_IsValid(t *testing.T) { if invalidProvider.IsValid() { t.Error("provider shouldn't have been valid") } - validProvider := AlertProvider{WebhookURL: "http://example.com"} + validProvider := AlertProvider{WebhookURL: "https://example.com"} if !validProvider.IsValid() { t.Error("provider should've been valid") } diff --git a/alerting/provider/teams/teams.go b/alerting/provider/teams/teams.go index 500750c2..e2351ad8 100644 --- a/alerting/provider/teams/teams.go +++ b/alerting/provider/teams/teams.go @@ -47,10 +47,10 @@ func (provider *AlertProvider) Send(endpoint *core.Endpoint, alert *alert.Alert, func (provider *AlertProvider) buildRequestBody(endpoint *core.Endpoint, alert *alert.Alert, result *core.Result, resolved bool) string { var message, color string if resolved { - message = fmt.Sprintf("An alert for *%s* has been resolved after passing successfully %d time(s) in a row", endpoint.Name, alert.SuccessThreshold) + message = fmt.Sprintf("An alert for *%s* has been resolved after passing successfully %d time(s) in a row", endpoint.DisplayName(), alert.SuccessThreshold) color = "#36A64F" } else { - message = fmt.Sprintf("An alert for *%s* has been triggered due to having failed %d time(s) in a row", endpoint.Name, alert.FailureThreshold) + message = fmt.Sprintf("An alert for *%s* has been triggered due to having failed %d time(s) in a row", endpoint.DisplayName(), alert.FailureThreshold) color = "#DD0000" } var results string diff --git a/alerting/provider/telegram/telegram.go b/alerting/provider/telegram/telegram.go index eb5a59f0..7a109f56 100644 --- a/alerting/provider/telegram/telegram.go +++ b/alerting/provider/telegram/telegram.go @@ -48,9 +48,9 @@ func (provider *AlertProvider) Send(endpoint *core.Endpoint, alert *alert.Alert, func (provider *AlertProvider) buildRequestBody(endpoint *core.Endpoint, alert *alert.Alert, result *core.Result, resolved bool) string { var message, results string if resolved { - message = fmt.Sprintf("An alert for *%s* has been resolved:\\n—\\n _healthcheck passing successfully %d time(s) in a row_\\n— ", endpoint.Name, alert.FailureThreshold) + message = fmt.Sprintf("An alert for *%s* has been resolved:\\n—\\n _healthcheck passing successfully %d time(s) in a row_\\n— ", endpoint.DisplayName(), alert.FailureThreshold) } else { - message = fmt.Sprintf("An alert for *%s* has been triggered:\\n—\\n _healthcheck failed %d time(s) in a row_\\n— ", endpoint.Name, alert.FailureThreshold) + message = fmt.Sprintf("An alert for *%s* has been triggered:\\n—\\n _healthcheck failed %d time(s) in a row_\\n— ", endpoint.DisplayName(), alert.FailureThreshold) } for _, conditionResult := range result.ConditionResults { var prefix string diff --git a/alerting/provider/twilio/twilio.go b/alerting/provider/twilio/twilio.go index d03347fd..ed0a04e3 100644 --- a/alerting/provider/twilio/twilio.go +++ b/alerting/provider/twilio/twilio.go @@ -53,9 +53,9 @@ func (provider *AlertProvider) Send(endpoint *core.Endpoint, alert *alert.Alert, func (provider *AlertProvider) buildRequestBody(endpoint *core.Endpoint, alert *alert.Alert, result *core.Result, resolved bool) string { var message string if resolved { - message = fmt.Sprintf("RESOLVED: %s - %s", endpoint.Name, alert.GetDescription()) + message = fmt.Sprintf("RESOLVED: %s - %s", endpoint.DisplayName(), alert.GetDescription()) } else { - message = fmt.Sprintf("TRIGGERED: %s - %s", endpoint.Name, alert.GetDescription()) + message = fmt.Sprintf("TRIGGERED: %s - %s", endpoint.DisplayName(), alert.GetDescription()) } return url.Values{ "To": {provider.To},