phares3757/gatus
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Change test structure into tabledriven

Browse Source 
Review change
Update README.md
This commit is contained in:
cemturker
2020-11-18 18:51:22 +01:00
parent 4ad5c7b99c
commit 7f21fdee68
5 changed files with 102 additions and 47 deletions

6
core/condition.go

@ -20,10 +20,10 @@ const (
// Values that could replace the placeholder: 127.0.0.1, 10.0.0.1, ...
IPPlaceHolder = "[IP]"
// DNSRCode is a place holder for DNS_RCODE
// DNSRCodePlaceHolder is a place holder for DNS_RCODE
//
// Values that could be NOERROR, FORMERR, SERVFAIL, NXDOMAIN, NOTIMP and REFUSED
DNSRCode = "[DNS_RCODE]"
DNSRCodePlaceHolder = "[DNS_RCODE]"
// ResponseTimePlaceHolder is a placeholder for the request response time, in milliseconds.
//
@ -148,7 +148,7 @@ func sanitizeAndResolve(list []string, result *Result) []string {
element = result.IP
case ResponseTimePlaceHolder:
element = strconv.Itoa(int(result.Duration.Milliseconds()))
case DNSRCode:
case DNSRCodePlaceHolder:
element = result.DNSRCode
case BodyPlaceHolder:
element = body

4
core/dns.go

@ -20,7 +20,7 @@ const (
)
type DNS struct {
// QueryType is the type for the DNS records like A,AAAA, CNAME...
// QueryType is the type for the DNS records like A, AAAA, CNAME...
QueryType string `yaml:"query-type"`
// QueryName is the query for DNS
QueryName string `yaml:"query-name"`
@ -77,7 +77,7 @@ func (d *DNS) query(url string, result *Result) {
result.Body = []byte(ns.Ns)
}
default:
result.Body = []byte("not supported")
result.Body = []byte("query type is not supported yet")
}
}
}

108
core/dns_test.go

@ -5,22 +5,102 @@ import (
)
func TestIntegrationQuery(t *testing.T) {
dns := DNS{
QueryType: "A",
QueryName: "example.com",
}
result := &Result{}
dns.validateAndSetDefault()
dns.query("8.8.8.8", result)
if len(result.Errors) != 0 {
t.Errorf("there should be no error Errors:%v", result.Errors)
tests := []struct {
name string
inputDNS DNS
inputURL string
expectedDNSCode string
expectedBody string
}{
{
name: "test DNS with type A",
inputDNS: DNS{
QueryType: "A",
QueryName: "example.com",
},
inputURL: "8.8.8.8",
expectedDNSCode: "NOERROR",
expectedBody: "93.184.216.34",
},
{
name: "test DNS with type AAAA",
inputDNS: DNS{
QueryType: "AAAA",
QueryName: "example.com",
},
inputURL: "8.8.8.8",
expectedDNSCode: "NOERROR",
expectedBody: "2606:2800:220:1:248:1893:25c8:1946",
},
{
name: "test DNS with type CNAME",
inputDNS: DNS{
QueryType: "CNAME",
QueryName: "example.com",
},
inputURL: "8.8.8.8",
expectedDNSCode: "NOERROR",
expectedBody: "",
},
{
name: "test DNS with type MX",
inputDNS: DNS{
QueryType: "MX",
QueryName: "example.com",
},
inputURL: "8.8.8.8",
expectedDNSCode: "NOERROR",
expectedBody: ".",
},
{
name: "test DNS with type NS",
inputDNS: DNS{
QueryType: "NS",
QueryName: "example.com",
},
inputURL: "8.8.8.8",
expectedDNSCode: "NOERROR",
expectedBody: "b.iana-servers.net.",
},
}
if result.DNSRCode != "NOERROR" {
t.Errorf("DNSRCode '%s' should have been NOERROR", result.DNSRCode)
}
for _, test := range tests {
test := test
t.Run(test.name, func(t *testing.T) {
dns := test.inputDNS
result := &Result{}
dns.validateAndSetDefault()
dns.query(test.inputURL, result)
if len(result.Errors) != 0 {
t.Errorf("there should be no error Errors:%v", result.Errors)
}
if result.DNSRCode != test.expectedDNSCode {
t.Errorf("DNSRCodePlaceHolder '%s' should have been %s", result.DNSRCode, test.expectedDNSCode)
}
if string(result.Body) != "93.184.216.34" {
t.Errorf("expected result %s", "93.184.216.34")
if string(result.Body) != test.expectedBody {
t.Errorf("got %s, expected result %s,", string(result.Body), test.expectedBody)
}
})
}
}
func TestService_ValidateAndSetDefaultsWithNoDNSQueryName(t *testing.T) {
defer func() { recover() }()
dns := &DNS{
QueryType: "A",
QueryName: "",
}
dns.validateAndSetDefault()
t.Fatal("Should've panicked because service`s dns didn't have a query name, which is a mandatory field for dns")
}
func TestService_ValidateAndSetDefaultsWithInvalidDNSQueryType(t *testing.T) {
defer func() { recover() }()
dns := &DNS{
QueryType: "B",
QueryName: "example.com",
}
dns.validateAndSetDefault()
t.Fatal("Should've panicked because service`s dns query type is invalid, it needs to be a valid query name like A, AAAA, CNAME...")
}

28
core/service_test.go

@ -72,34 +72,6 @@ func TestService_ValidateAndSetDefaultsWithNoConditions(t *testing.T) {
t.Fatal("Should've panicked because service didn't have at least 1 condition")
}
func TestService_ValidateAndSetDefaultsWithNoDNSQueryName(t *testing.T) {
defer func() { recover() }()
service := &Service{
Name: "",
URL: "http://example.com",
DNS: &DNS{
QueryType: "A",
QueryName: "",
},
}
service.ValidateAndSetDefaults()
t.Fatal("Should've panicked because service`s dns didn't have a query name, which is a mandatory field for dns")
}
func TestService_ValidateAndSetDefaultsWithInvalidDNSQueryType(t *testing.T) {
defer func() { recover() }()
service := &Service{
Name: "",
URL: "http://example.com",
DNS: &DNS{
QueryType: "B",
QueryName: "example.com",
},
}
service.ValidateAndSetDefaults()
t.Fatal("Should've panicked because service`s dns query type is invalid, it needs to be a valid query name like A, AAAA, CNAME...")
}
func TestService_ValidateAndSetDefaultsWithDNS(t *testing.T) {
conditionSuccess := Condition("[DNS_RCODE] == NOERROR")
service := &Service{