phares3757/gatus
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve test coverage

Browse Source
This commit is contained in:
TwinProduction
2021-05-15 22:09:58 -04:00
parent 77de4c4742
commit 758428b312
3 changed files with 39 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
alerting/provider/discord/discord.go
View File

@ -16,27 +16,6 @@ type AlertProvider struct {
DefaultAlert *core.Alert `yaml:"default-alert"`
}
//func (provider *AlertProvider) ParseWithDefaultAlert(alert *core.Alert) {
// if provider.DefaultAlert == nil {
// return
// }
// if alert.Enabled == nil {
// alert.Enabled = provider.DefaultAlert.Enabled
// }
// if alert.SendOnResolved == nil {
// alert.SendOnResolved = provider.DefaultAlert.SendOnResolved
// }
// if len(alert.Description) == 0 {
// alert.Description = provider.DefaultAlert.Description
// }
// if alert.FailureThreshold == 0 {
// alert.FailureThreshold = provider.DefaultAlert.FailureThreshold
// }
// if alert.SuccessThreshold == 0 {
// alert.SuccessThreshold = provider.DefaultAlert.SuccessThreshold
// }
//}
// IsValid returns whether the provider's configuration is valid
func (provider *AlertProvider) IsValid() bool {
return len(provider.WebhookURL) > 0

4
alerting/provider/provider_test.go
View File

@ -47,7 +47,7 @@ func TestParseWithDefaultAlert(t *testing.T) {
SuccessThreshold: 10,
},
ServiceAlert: &core.Alert{
Type: core.DiscordAlert,
Type: core.TelegramAlert,
Enabled: &enabled,
SendOnResolved: &enabled,
Description: &secondDescription,
@ -55,7 +55,7 @@ func TestParseWithDefaultAlert(t *testing.T) {
SuccessThreshold: 11,
},
ExpectedOutputAlert: &core.Alert{
Type: core.DiscordAlert,
Type: core.TelegramAlert,
Enabled: &enabled,
SendOnResolved: &enabled,
Description: &secondDescription,