Rename Service to Endpoint (#192)

* Add clarifications in comments

* #191: Rename Service to Endpoint

util/key.go

@@ -2,9 +2,9 @@ package util
 
 import "strings"
 
-// ConvertGroupAndServiceToKey converts a group and a service to a key
-func ConvertGroupAndServiceToKey(group, service string) string {
-	return sanitize(group) + "_" + sanitize(service)
+// ConvertGroupAndEndpointNameToKey converts a group and an endpoint to a key
+func ConvertGroupAndEndpointNameToKey(group, endpoint string) string {
+	return sanitize(group) + "_" + sanitize(endpoint)
 }
 
 func sanitize(s string) string {

util/key_bench_test.go

@@ -4,8 +4,8 @@ import (
 	"testing"
 )
 
-func BenchmarkConvertGroupAndServiceToKey(b *testing.B) {
+func BenchmarkConvertGroupAndEndpointNameToKey(b *testing.B) {
 	for n := 0; n < b.N; n++ {
-		ConvertGroupAndServiceToKey("group", "service")
+		ConvertGroupAndEndpointNameToKey("group", "name")
 	}
 }

util/key_test.go

@@ -2,34 +2,34 @@ package util
 
 import "testing"
 
-func TestConvertGroupAndServiceToKey(t *testing.T) {
+func TestConvertGroupAndEndpointNameToKey(t *testing.T) {
 	type Scenario struct {
 		GroupName      string
-		ServiceName    string
+		EndpointName   string
 		ExpectedOutput string
 	}
 	scenarios := []Scenario{
 		{
 			GroupName:      "Core",
-			ServiceName:    "Front End",
+			EndpointName:   "Front End",
 			ExpectedOutput: "core_front-end",
 		},
 		{
 			GroupName:      "Load balancers",
-			ServiceName:    "us-west-2",
+			EndpointName:   "us-west-2",
 			ExpectedOutput: "load-balancers_us-west-2",
 		},
 		{
 			GroupName:      "a/b test",
-			ServiceName:    "a",
+			EndpointName:   "a",
 			ExpectedOutput: "a-b-test_a",
 		},
 	}
 	for _, scenario := range scenarios {
 		t.Run(scenario.ExpectedOutput, func(t *testing.T) {
-			output := ConvertGroupAndServiceToKey(scenario.GroupName, scenario.ServiceName)
+			output := ConvertGroupAndEndpointNameToKey(scenario.GroupName, scenario.EndpointName)
 			if output != scenario.ExpectedOutput {
-				t.Errorf("Expected '%s', got '%s'", scenario.ExpectedOutput, output)
+				t.Errorf("expected '%s', got '%s'", scenario.ExpectedOutput, output)
 			}
 		})
 	}