feat(api): Migrate from gorilla/mux to fiber

Fixes #468

security/config_test.go

@@ -5,7 +5,7 @@ import (
 	"net/http/httptest"
 	"testing"
 
-	"github.com/gorilla/mux"
+	"github.com/gofiber/fiber/v2"
 	"golang.org/x/oauth2"
 )
 
@@ -23,83 +23,96 @@ func TestConfig_ApplySecurityMiddleware(t *testing.T) {
 	///////////
 	// BASIC //
 	///////////
-	// Bcrypt
-	c := &Config{Basic: &BasicConfig{
-		Username:                        "john.doe",
-		PasswordBcryptHashBase64Encoded: "JDJhJDA4JDFoRnpPY1hnaFl1OC9ISlFsa21VS09wOGlPU1ZOTDlHZG1qeTFvb3dIckRBUnlHUmNIRWlT",
-	}}
-	api := mux.NewRouter()
-	api.HandleFunc("/test", func(w http.ResponseWriter, r *http.Request) {
-		w.WriteHeader(http.StatusOK)
+	t.Run("basic", func(t *testing.T) {
+		// Bcrypt
+		c := &Config{Basic: &BasicConfig{
+			Username:                        "john.doe",
+			PasswordBcryptHashBase64Encoded: "JDJhJDA4JDFoRnpPY1hnaFl1OC9ISlFsa21VS09wOGlPU1ZOTDlHZG1qeTFvb3dIckRBUnlHUmNIRWlT",
+		}}
+		app := fiber.New()
+		if err := c.ApplySecurityMiddleware(app); err != nil {
+			t.Error("expected no error, got", err)
+		}
+		app.Get("/test", func(c *fiber.Ctx) error {
+			return c.SendStatus(200)
+		})
+		// Try to access the route without basic auth
+		request := httptest.NewRequest("GET", "/test", http.NoBody)
+		response, err := app.Test(request)
+		if err != nil {
+			t.Fatal("expected no error, got", err)
+		}
+		if response.StatusCode != 401 {
+			t.Error("expected code to be 401, but was", response.StatusCode)
+		}
+		// Try again, but with basic auth
+		request = httptest.NewRequest("GET", "/test", http.NoBody)
+		request.SetBasicAuth("john.doe", "hunter2")
+		response, err = app.Test(request)
+		if err != nil {
+			t.Fatal("expected no error, got", err)
+		}
+		if response.StatusCode != 200 {
+			t.Error("expected code to be 200, but was", response.StatusCode)
+		}
 	})
-	if err := c.ApplySecurityMiddleware(api); err != nil {
-		t.Error("expected no error, but was", err)
-	}
-	// Try to access the route without basic auth
-	request, _ := http.NewRequest("GET", "/test", http.NoBody)
-	responseRecorder := httptest.NewRecorder()
-	api.ServeHTTP(responseRecorder, request)
-	if responseRecorder.Code != http.StatusUnauthorized {
-		t.Error("expected code to be 401, but was", responseRecorder.Code)
-	}
-	// Try again, but with basic auth
-	request, _ = http.NewRequest("GET", "/test", http.NoBody)
-	responseRecorder = httptest.NewRecorder()
-	request.SetBasicAuth("john.doe", "hunter2")
-	api.ServeHTTP(responseRecorder, request)
-	if responseRecorder.Code != http.StatusOK {
-		t.Error("expected code to be 200, but was", responseRecorder.Code)
-	}
 	//////////
 	// OIDC //
 	//////////
-	api = mux.NewRouter()
-	api.HandleFunc("/test", func(w http.ResponseWriter, r *http.Request) {
-		w.WriteHeader(http.StatusOK)
+	t.Run("oidc", func(t *testing.T) {
+		c := &Config{OIDC: &OIDCConfig{
+			IssuerURL:       "https://sso.gatus.io/",
+			RedirectURL:     "http://localhost:80/authorization-code/callback",
+			Scopes:          []string{"openid"},
+			AllowedSubjects: []string{"user1@example.com"},
+			oauth2Config:    oauth2.Config{},
+			verifier:        nil,
+		}}
+		app := fiber.New()
+		if err := c.ApplySecurityMiddleware(app); err != nil {
+			t.Error("expected no error, got", err)
+		}
+		app.Get("/test", func(c *fiber.Ctx) error {
+			return c.SendStatus(200)
+		})
+		// Try without any session cookie
+		request := httptest.NewRequest("GET", "/test", http.NoBody)
+		response, err := app.Test(request)
+		if err != nil {
+			t.Fatal("expected no error, got", err)
+		}
+		if response.StatusCode != 401 {
+			t.Error("expected code to be 401, but was", response.StatusCode)
+		}
+		// Try with a session cookie
+		request = httptest.NewRequest("GET", "/test", http.NoBody)
+		request.AddCookie(&http.Cookie{Name: "session", Value: "123"})
+		response, err = app.Test(request)
+		if err != nil {
+			t.Fatal("expected no error, got", err)
+		}
+		if response.StatusCode != 401 {
+			t.Error("expected code to be 401, but was", response.StatusCode)
+		}
 	})
-	c.OIDC = &OIDCConfig{
-		IssuerURL:       "https://sso.gatus.io/",
-		RedirectURL:     "http://localhost:80/authorization-code/callback",
-		Scopes:          []string{"openid"},
-		AllowedSubjects: []string{"user1@example.com"},
-		oauth2Config:    oauth2.Config{},
-		verifier:        nil,
-	}
-	c.Basic = nil
-	if err := c.ApplySecurityMiddleware(api); err != nil {
-		t.Error("expected no error, but was", err)
-	}
-	// Try without any session cookie
-	request, _ = http.NewRequest("GET", "/test", http.NoBody)
-	responseRecorder = httptest.NewRecorder()
-	api.ServeHTTP(responseRecorder, request)
-	if responseRecorder.Code != http.StatusUnauthorized {
-		t.Error("expected code to be 401, but was", responseRecorder.Code)
-	}
-	// Try with a session cookie
-	request, _ = http.NewRequest("GET", "/test", http.NoBody)
-	request.AddCookie(&http.Cookie{Name: "session", Value: "123"})
-	responseRecorder = httptest.NewRecorder()
-	api.ServeHTTP(responseRecorder, request)
-	if responseRecorder.Code != http.StatusUnauthorized {
-		t.Error("expected code to be 401, but was", responseRecorder.Code)
-	}
 }
 
 func TestConfig_RegisterHandlers(t *testing.T) {
 	c := &Config{}
-	router := mux.NewRouter()
-	c.RegisterHandlers(router)
+	app := fiber.New()
+	c.RegisterHandlers(app)
 	// Try to access the OIDC handler. This should fail, because the security config doesn't have OIDC
-	request, _ := http.NewRequest("GET", "/oidc/login", http.NoBody)
-	responseRecorder := httptest.NewRecorder()
-	router.ServeHTTP(responseRecorder, request)
-	if responseRecorder.Code != http.StatusNotFound {
-		t.Error("expected code to be 404, but was", responseRecorder.Code)
+	request := httptest.NewRequest("GET", "/oidc/login", http.NoBody)
+	response, err := app.Test(request)
+	if err != nil {
+		t.Fatal("expected no error, got", err)
+	}
+	if response.StatusCode != 404 {
+		t.Error("expected code to be 404, but was", response.StatusCode)
 	}
 	// Set an empty OIDC config. This should fail, because the IssuerURL is required.
 	c.OIDC = &OIDCConfig{}
-	if err := c.RegisterHandlers(router); err == nil {
+	if err := c.RegisterHandlers(app); err == nil {
 		t.Fatal("expected an error, but got none")
 	}
 	// Set the OIDC config and try again
@@ -109,13 +122,15 @@ func TestConfig_RegisterHandlers(t *testing.T) {
 		Scopes:          []string{"openid"},
 		AllowedSubjects: []string{"user1@example.com"},
 	}
-	if err := c.RegisterHandlers(router); err != nil {
+	if err := c.RegisterHandlers(app); err != nil {
 		t.Fatal("expected no error, but got", err)
 	}
-	request, _ = http.NewRequest("GET", "/oidc/login", http.NoBody)
-	responseRecorder = httptest.NewRecorder()
-	router.ServeHTTP(responseRecorder, request)
-	if responseRecorder.Code != http.StatusFound {
-		t.Error("expected code to be 302, but was", responseRecorder.Code)
+	request = httptest.NewRequest("GET", "/oidc/login", http.NoBody)
+	response, err = app.Test(request)
+	if err != nil {
+		t.Fatal("expected no error, got", err)
+	}
+	if response.StatusCode != 302 {
+		t.Error("expected code to be 302, but was", response.StatusCode)
 	}
 }