Close #14: Support skipping certificate verification (services[].insecure)

client/client.go

@@ -1,19 +1,35 @@
 package client
 
 import (
+	"crypto/tls"
 	"net/http"
 	"time"
 )
 
 var (
-	client *http.Client
+	secureHttpClient   *http.Client
+	insecureHttpClient *http.Client
 )
 
-func GetHttpClient() *http.Client {
-	if client == nil {
-		client = &http.Client{
-			Timeout: time.Second * 10,
+func GetHttpClient(insecure bool) *http.Client {
+	if insecure {
+		if insecureHttpClient == nil {
+			insecureHttpClient = &http.Client{
+				Timeout: time.Second * 10,
+				Transport: &http.Transport{
+					TLSClientConfig: &tls.Config{
+						InsecureSkipVerify: true,
+					},
+				},
+			}
 		}
+		return insecureHttpClient
+	} else {
+		if secureHttpClient == nil {
+			secureHttpClient = &http.Client{
+				Timeout: time.Second * 10,
+			}
+		}
+		return secureHttpClient
 	}
-	return client
 }

client/client_test.go

@@ -3,11 +3,24 @@ package client
 import "testing"
 
 func TestGetHttpClient(t *testing.T) {
-	if client != nil {
-		t.Error("client should've been nil since it hasn't been called a single time yet")
+	if secureHttpClient != nil {
+		t.Error("secureHttpClient should've been nil since it hasn't been called a single time yet")
 	}
-	_ = GetHttpClient()
-	if client == nil {
-		t.Error("client shouldn't have been nil, since it has been called once")
+	if insecureHttpClient != nil {
+		t.Error("insecureHttpClient should've been nil since it hasn't been called a single time yet")
+	}
+	_ = GetHttpClient(false)
+	if secureHttpClient == nil {
+		t.Error("secureHttpClient shouldn't have been nil, since it has been called once")
+	}
+	if insecureHttpClient != nil {
+		t.Error("insecureHttpClient should've been nil since it hasn't been called a single time yet")
+	}
+	_ = GetHttpClient(true)
+	if secureHttpClient == nil {
+		t.Error("secureHttpClient shouldn't have been nil, since it has been called once")
+	}
+	if insecureHttpClient == nil {
+		t.Error("insecureHttpClient shouldn't have been nil, since it has been called once")
 	}
 }