From 1a708ebca26518f9b814d79bf3f597e36b21ca1d Mon Sep 17 00:00:00 2001 From: TwiN Date: Sun, 9 Oct 2022 16:34:08 -0400 Subject: [PATCH] test(alerting): Fix tests following change to defaults --- alerting/provider/ntfy/ntfy_test.go | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/alerting/provider/ntfy/ntfy_test.go b/alerting/provider/ntfy/ntfy_test.go index be0fff95..f2981ea8 100644 --- a/alerting/provider/ntfy/ntfy_test.go +++ b/alerting/provider/ntfy/ntfy_test.go @@ -14,9 +14,9 @@ func TestAlertDefaultProvider_IsValid(t *testing.T) { expected: true, }, { - name: "invalid-url", - provider: AlertProvider{URL: "", Topic: "example", Priority: 1}, - expected: false, + name: "no-url-should-use-default-value", + provider: AlertProvider{Topic: "example", Priority: 1}, + expected: true, }, { name: "invalid-topic", @@ -30,9 +30,14 @@ func TestAlertDefaultProvider_IsValid(t *testing.T) { }, { name: "invalid-priority-too-low", - provider: AlertProvider{URL: "https://ntfy.sh", Topic: "example", Priority: 0}, + provider: AlertProvider{URL: "https://ntfy.sh", Topic: "example", Priority: -1}, expected: false, }, + { + name: "no-priority-should-use-default-value", + provider: AlertProvider{URL: "https://ntfy.sh", Topic: "example"}, + expected: true, + }, } for _, scenario := range scenarios { t.Run(scenario.name, func(t *testing.T) {