Pull Request 33523 suggestions

Pull Request 33520 suggestions

Injected AppSettings instead of using GetEnvironmentVariable at Services level

When debugging only
app.Services.GetRequiredService<IPCRBService>();

Get ready to use VSCode IDE

Align .editorconfig files

.editorconfig

@@ -19,7 +19,7 @@ insert_final_newline = false
 
 # Organize usings
 dotnet_separate_import_directive_groups = true
-dotnet_sort_system_directives_first = false
+dotnet_sort_system_directives_first = true
 file_header_template = unset
 
 # this. and Me. preferences
@@ -249,4 +249,39 @@ dotnet_style_operator_placement_when_wrapping = beginning_of_line
 tab_width = 4
 indent_size = 4
 end_of_line = crlf
-dotnet_style_prefer_collection_expression = when_types_loosely_match:suggestion
+dotnet_style_prefer_collection_expression = when_types_loosely_match:suggestion
+
+# Question
+
+csharp_style_inlined_variable_declaration = false
+csharp_style_prefer_primary_constructors = false
+dotnet_diagnostic.CA1510.severity = none # "Use 'ArgumentNullException.ThrowIfNull' instead of explicitly throwing a new exception instance
+dotnet_diagnostic.CA1806.severity = none # SendEmailWithValidArgsShouldSendMailThroughClient calls TryParse but does not explicitly
+dotnet_diagnostic.CA1827.severity = none # Count() is used where Any() could be used instead to improve performance
+dotnet_diagnostic.CA1829.severity = none # Use the property instead of Enumerable.Count()
+dotnet_diagnostic.CA1860.severity = none # Prefer comparing 'Count' to 0 rather than using 'Any()', both for clarity and for performance
+dotnet_diagnostic.CA2208.severity = none # Method .ctor passes
+dotnet_diagnostic.CA2208.severity = none # Method .ctor passes
+dotnet_diagnostic.CA2211.severity = none # Non-constant fields should not be visible
+dotnet_diagnostic.CA2253.severity = none # Named placeholders in the logging message template should not be comprised
+dotnet_diagnostic.CA2254.severity = none # The logging message template should not vary between calls to
+dotnet_diagnostic.CS1998.severity = none # This async method lacks 'await' operators and will run synchronously
+dotnet_diagnostic.CS8618.severity = none # Non-nullable field '_mockDalService' must contain a non-null value when exiting constructor
+dotnet_diagnostic.CS8625.severity = none # Cannot convert null literal to non-nullable reference type
+dotnet_diagnostic.IDE0005.severity = none # Using directive is unnecessary.
+dotnet_diagnostic.IDE0017.severity = none # Object initialization can be simplified
+dotnet_diagnostic.IDE0018.severity = none # Variable declaration can be inlined
+dotnet_diagnostic.IDE0028.severity = none # Collection initialization can be simplified
+dotnet_diagnostic.IDE0044.severity = none # Make field readonly
+dotnet_diagnostic.IDE0046.severity = none # 'if' statement can be simplified
+dotnet_diagnostic.IDE0052.severity = none # "Private member can be removed
+dotnet_diagnostic.IDE0270.severity = none # Null check can be simplified
+dotnet_diagnostic.IDE0290.severity = none # Use primary constructor
+dotnet_diagnostic.IDE1006.severity = none # Naming rule violation: These words must begin with upper case characters
+dotnet_diagnostic.IDE2000.severity = error # IDE2000: Allow multiple blank lines
+dotnet_diagnostic.NUnit2001.severity = none # Consider using the constraint model, Assert.That(expr, Is.False), instead of the classic model
+dotnet_diagnostic.NUnit2004.severity = none # Consider using the constraint model
+dotnet_diagnostic.NUnit2010.severity = none # Use Is.EqualTo constraint instead of direct comparison for better assertion messages in ca
+dotnet_style_coalesce_expression = false
+dotnet_style_object_initializer = false
+dotnet_style_prefer_conditional_expression_over_return = false